Migrate to dhall 1.26.1 and merge types and terms #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clementd-fretlink
force-pushed
the
polykinds
branch
from
c8204ea to
1a9a02a
Compare
clementd-fretlink
changed the title
|
ah great point, I wasn't aware of this convention. I'll make the change |
|
(if there are other conventions I'm not following, please tell me) |
clementd-fretlink
force-pushed
the
polykinds
branch
2 times, most recently
from
8f51cc1 to
0505d02
Compare
paulrbr-fl
reviewed
Oct 2, 2019
paulrbr-fl
reviewed
Oct 2, 2019
clementd-fretlink
force-pushed
the
polykinds
branch
from
0505d02 to
2acb3d4
Compare
paulrbr-fl
reviewed
Oct 2, 2019
|
« je vois que nous en sommes arrivés à la même conclusion, avec cependant un léger avantage pour moi : j'ai remis les .dhall » (extremely OSS117 voice) |
paulrbr-fl
approved these changes
Oct 2, 2019
|
Yeah, I'm quite happy with it :-) |
paulrbr-fl
approved these changes
Oct 4, 2019
clementd-fretlink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest dhall version allows to have types and terms in a given record. That allows to use records as proper modules without having separate files for types and terms.
Since all the files are small here, I merged related types and terms. I think it improves clarity (by improving locality)
Things to look at
I've loosely followed the conventions used in
Prelude(https://github.com/dhall-lang/dhall-lang/tree/master/Prelude):package.dhallfile per dirTypeWhat I did not follow:
AddonandConfig, the type is defined inline instead of in a separate file. The multiple files containing a single line made navigating ourcodeconfigbase tedious, so improving locality is a net improvement imo.dhallextension (omitting it would break our tooling or would require brittle config rules)ToDo
I'd like to test an end-to-end